zhengruifeng commented on code in PR #37835: URL: https://github.com/apache/spark/pull/37835#discussion_r966589834
########## python/pyspark/pandas/tests/test_expanding.py: ########## @@ -26,37 +26,33 @@ class ExpandingTest(PandasOnSparkTestCase, TestUtils): - def _test_expanding_func(self, f): Review Comment: what about make `f` here accept both `str` and `function`? Then when we need to pass some parameter into the function, it could be a `lambda`; (but it seems that no such case right now?) otherwise, still keep existing logic. also cc @itholic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
