cloud-fan commented on code in PR #37841:
URL: https://github.com/apache/spark/pull/37841#discussion_r966738071
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ExpressionTypeCheckingSuite.scala:
##########
@@ -77,12 +77,6 @@ class ExpressionTypeCheckingSuite extends SparkFunSuite with
SQLHelper {
}
test("check types for binary arithmetic") {
- // We will cast String to Double for binary arithmetic
- assertSuccess(Add($"intField", $"stringField"))
- assertSuccess(Subtract($"intField", $"stringField"))
- assertSuccess(Multiply($"intField", $"stringField"))
- assertSuccess(Divide($"intField", $"stringField"))
- assertSuccess(Remainder($"intField", $"stringField"))
Review Comment:
why remove these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
