cloud-fan commented on code in PR #37830:
URL: https://github.com/apache/spark/pull/37830#discussion_r966747029
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala:
##########
@@ -184,68 +184,56 @@ final class Decimal extends Ordered[Decimal] with
Serializable {
this
}
- def toBigDecimal: BigDecimal = {
- if (decimalVal.ne(null)) {
- decimalVal
- } else {
- BigDecimal(longVal, _scale)
- }
+ def toBigDecimal: BigDecimal = if (decimalVal.ne(null)) {
Review Comment:
can we avoid pure code style change? the previous code style was not wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
