cloud-fan commented on code in PR #37831:
URL: https://github.com/apache/spark/pull/37831#discussion_r966804738
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala:
##########
@@ -477,7 +480,7 @@ case class DataSource(
// will be adjusted within InsertIntoHadoopFsRelation.
InsertIntoHadoopFsRelationCommand(
outputPath = outputPath,
- staticPartitions = Map.empty,
+ staticPartitions = staticPartitions,
Review Comment:
the downstream projects and detect real dynamic partition columns by
themselves. I'd prefer a simple solution here to just remove local sort.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala:
##########
@@ -477,7 +480,7 @@ case class DataSource(
// will be adjusted within InsertIntoHadoopFsRelation.
InsertIntoHadoopFsRelationCommand(
outputPath = outputPath,
- staticPartitions = Map.empty,
+ staticPartitions = staticPartitions,
Review Comment:
the downstream projects can detect real dynamic partition columns by
themselves. I'd prefer a simple solution here to just remove local sort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
