LuciferYang commented on code in PR #37843:
URL: https://github.com/apache/spark/pull/37843#discussion_r967611052


##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Expression.java:
##########
@@ -44,7 +44,16 @@ public interface Expression {
    * List of fields or columns that are referenced by this expression.
    */
   default NamedReference[] references() {

Review Comment:
   Use following method build test object
   
   ```
    public static TestObj[] objs(int length, int size, int range) {
           TestObj[] objects = new TestObj[length];
           for (int i = 0; i < length; i++) {
               objects[i] = new TestObj(size, range);
           }
           return objects;
       }
   ```
   
   and test `length, size, range`:
   
   -1, 5, 100
   - 5, 5, 100
   - 10, 5, 100
   - 20, 5, 100
   - 50, 5, 100
   - 100, 5, 100
   - 500, 5, 100
   - 1000, 5, 100



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to