MaxGekk commented on code in PR #37834:
URL: https://github.com/apache/spark/pull/37834#discussion_r968234159
##########
core/src/main/java/org/apache/spark/memory/SparkOutOfMemoryError.java:
##########
@@ -38,15 +40,15 @@ public SparkOutOfMemoryError(OutOfMemoryError e) {
super(e.getMessage());
}
- public SparkOutOfMemoryError(String errorClass, String[]
messageParameters) {
+ public SparkOutOfMemoryError(String errorClass, Map<String, String>
messageParameters) {
super(SparkThrowableHelper.getMessage(errorClass, null,
messageParameters));
this.errorClass = errorClass;
this.messageParameters = messageParameters;
}
@Override
public String[] getMessageParameters() {
- return messageParameters;
+ return SparkThrowableHelper.getMessageParameters(errorClass, null,
messageParameters);
Review Comment:
This is tested by ShuffleExternalSorterSuite "nested spill should be no-op"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
