cloud-fan commented on code in PR #37834:
URL: https://github.com/apache/spark/pull/37834#discussion_r969146280
##########
core/src/main/scala/org/apache/spark/SparkException.scala:
##########
@@ -128,13 +140,16 @@ private[spark] case class ExecutorDeadException(message:
String)
private[spark] class SparkUpgradeException(
errorClass: String,
errorSubClass: Option[String] = None,
- messageParameters: Array[String],
+ messageParameters: Map[String, String],
cause: Throwable)
- extends RuntimeException(SparkThrowableHelper.getMessage(errorClass,
errorSubClass.orNull,
- messageParameters), cause)
- with SparkThrowable {
+ extends RuntimeException(
+ SparkThrowableHelper.getMessage(errorClass, errorSubClass.orNull,
messageParameters), cause)
+ with SparkThrowable {
+
+ override def getMessageParameters: Array[String] = {
+ SparkThrowableHelper.getMessageParameters(errorClass,
errorSubClass.orNull, messageParameters)
Review Comment:
+1. These 2 methods were added by https://github.com/apache/spark/pull/36693
and not released yet. We can still change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
