cloud-fan commented on code in PR #37407: URL: https://github.com/apache/spark/pull/37407#discussion_r969644167
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ########## @@ -1378,28 +1378,84 @@ case class Pivot( * A constructor for creating an Unpivot, which will later be converted to an [[Expand]] * during the query analysis. * - * An empty values array will be replaced during analysis with all resolved outputs of child except + * Either ids or values array must be set. The ids array can be empty, + * the values array must not be empty if not None. + * + * A None ids array will be replaced during analysis with all resolved outputs of child except Review Comment: When can the `ids` be `Nonw`? Seems all the user-facing APIs require users to specify id columns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
