LuciferYang commented on code in PR #37876:
URL: https://github.com/apache/spark/pull/37876#discussion_r971408078
##########
core/src/main/scala/org/apache/spark/util/collection/Utils.scala:
##########
@@ -62,4 +63,30 @@ private[spark] object Utils {
*/
def sequenceToOption[T](input: Seq[Option[T]]): Option[Seq[T]] =
if (input.forall(_.isDefined)) Some(input.flatten) else None
+
+ /**
+ * Same function as `keys.zip(values).toMap`, but has perf gain.
+ */
+ def toMap[K, V](keys: Iterable[K], values: Iterable[V]): Map[K, V] = {
+ val builder = immutable.Map.newBuilder[K, V]
+ val keyIter = keys.iterator
+ val valueIter = values.iterator
+ while (keyIter.hasNext && valueIter.hasNext) {
+ builder += (keyIter.next(), valueIter.next()).asInstanceOf[(K, V)]
+ }
+ builder.result()
+ }
+
+ /**
+ * Same function as `keys.zip(values).toMap.asJava`, but has perf gain.
+ */
+ def toJavaMap[K, V](keys: Iterable[K], values: Iterable[V]):
java.util.Map[K, V] = {
+ val map = new java.util.HashMap[K, V]()
+ val keyIter = keys.iterator
+ val valueIter = values.iterator
+ while (keyIter.hasNext && valueIter.hasNext) {
+ map.put(keyIter.next(), valueIter.next())
+ }
+ map
Review Comment:
this method return a Java Map, how to make it immutable...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
