LuciferYang commented on code in PR #37853:
URL: https://github.com/apache/spark/pull/37853#discussion_r971589945
##########
docs/running-on-yarn.md:
##########
@@ -852,8 +852,8 @@ The following extra configuration options are available
when the shuffle service
<td><code>spark.shuffle.service.db.backend</code></td>
<td>LEVELDB</td>
<td>
- To specify the kind of disk-base store used in shuffle service state
store, supports `LEVELDB` and `ROCKSDB` now
- and `LEVELDB` as default value.
+ When work-preserving restart is enabled in YARN, this is used to specify
the disk-base store used
+ in shuffle service state store, supports `LEVELDB` and `ROCKSDB` with
`LEVELDB` as default value.
The original data store in `LevelDB/RocksDB` will not be automatically
convert to another kind of storage now.
Review Comment:
The old one will not be deleted, but the new one will be created. When the
store type is switched, the directory name will change, for example, from
`registeredExecutors.ldb` to `registeredExecutors.rdb`, `YarnShuffleService`
will create `registeredExecutors.rdb` if it not exists, but
`YarnShuffleService` did not know that `registeredExecutors.ldb` existed, so it
will not be deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
