cloud-fan commented on code in PR #37879:
URL: https://github.com/apache/spark/pull/37879#discussion_r972560446
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala:
##########
@@ -244,3 +246,9 @@ case class ResolvedIdentifier(
identifier: Identifier) extends LeafNodeWithoutStats {
override def output: Seq[Attribute] = Nil
}
+
+// A fake v2 catalog to hold temp views.
+object FakeSystemCatalog extends CatalogPlugin {
+ override def initialize(name: String, options: CaseInsensitiveStringMap):
Unit = {}
+ override def name(): String = "SYSTEM"
Review Comment:
the name doesn't matter. We won't show it or look it up for now. But I think
it's a good idea to add a system catalog officially, to host temp view, temp
functions and builtin functions.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala:
##########
@@ -244,3 +246,9 @@ case class ResolvedIdentifier(
identifier: Identifier) extends LeafNodeWithoutStats {
override def output: Seq[Attribute] = Nil
}
+
+// A fake v2 catalog to hold temp views.
+object FakeSystemCatalog extends CatalogPlugin {
+ override def initialize(name: String, options: CaseInsensitiveStringMap):
Unit = {}
+ override def name(): String = "SYSTEM"
Review Comment:
the name doesn't matter. We won't show it or look it up for now. But later I
think it's a good idea to add a system catalog officially, to host temp view,
temp functions and builtin functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
