ayushi-agarwal commented on code in PR #37625:
URL: https://github.com/apache/spark/pull/37625#discussion_r973547764


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala:
##########
@@ -412,6 +412,16 @@ object BooleanSimplification extends Rule[LogicalPlan] 
with PredicateHelper {
           }
         }
 
+      case Or(EqualTo(l, r), And(IsNull(c1), IsNull(c2)))

Review Comment:
   @cloud-fan I didn't generalize it because it would be tricky and will add 
complexity to code. Also it might be less common where these conditions are 
separated out with some other expressions in between.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to