jiaji-wu commented on code in PR #37348:
URL: https://github.com/apache/spark/pull/37348#discussion_r973553085


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanSuite.scala:
##########
@@ -143,6 +143,48 @@ class SparkPlanSuite extends QueryTest with 
SharedSparkSession {
       }
     }
   }
+
+  test("SPARK-39854: replaceWithAliases should keep the order of Generate 
children") {

Review Comment:
   Hi @dongjoon-hyun , thanks for taking time looking into this!
   
   The test is put in the `core` module (instead of the `catalyst` module) 
because it has dependency on things like `SparkSession`, `sql.functions`, which 
is only available there -- not sure where is the best place to put it, or are 
there better ways to re-write the test (my knowledge on that part is limited 😓).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to