dongjoon-hyun commented on code in PR #37348:
URL: https://github.com/apache/spark/pull/37348#discussion_r973642554
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanSuite.scala:
##########
@@ -143,6 +143,48 @@ class SparkPlanSuite extends QueryTest with
SharedSparkSession {
}
}
}
+
+ test("SPARK-39854: replaceWithAliases should keep the order of Generate
children") {
Review Comment:
If we add an end-to-end test, the Apache Spark test time increases
prohibitively. We prefer to narrow down the issue and have isolated unit tests.
So, in this PR, `NestedColumnAliasingSuite.scala` is the best place to have a
test coverage. In short, I don't think we need a heavy end-to-end test case
like this. We need to have a test case similar to the other in
`NestedColumnAliasingSuite.scala`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
