zhengruifeng commented on PR #37918: URL: https://github.com/apache/spark/pull/37918#issuecomment-1250409906
@dongjoon-hyun > could you make an independent PR moving TopByKeyAggregator to CollectTopK because that is orthogonal from Reduce the shuffle size of ALS? It is just the moving from `TopByKeyAggregator` to `CollectTopK` that reduce the shuffle size, since the ser/deser is optimized in `CollectTopK`, let me update the PR description > In addition, we need a test coverage for CollectTopK because we remove TopByKeyAggregatorSuite. Sure, will update soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
