kazuyukitanimura commented on code in PR #37934:
URL: https://github.com/apache/spark/pull/37934#discussion_r974775400
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala:
##########
@@ -1461,10 +1462,7 @@ class ParquetIOSuite extends QueryTest with ParquetTest
with SharedSparkSession
vectorizedReader.initBatch(schema, partitionValues)
vectorizedReader.nextKeyValue()
val row = vectorizedReader.getCurrentValue.asInstanceOf[InternalRow]
-
- // Use `GenericMutableRow` by explicitly copying rather than
`ColumnarBatch`
- // in order to use get(...) method which is not implemented in
`ColumnarBatch`.
- val actual = row.copy().get(1, dt)
Review Comment:
That's correct. The `copy()` converts `row` from `ColumnarBatchRow` to
`GenericInternalRow` and there null works.
With this PR, `null` is directly supported in `ColumnarBatchRow.get()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
