LuciferYang commented on code in PR #37943:
URL: https://github.com/apache/spark/pull/37943#discussion_r975211012
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala:
##########
@@ -1044,7 +1044,7 @@ trait ShowCreateTableCommandBase extends SQLConfHelper {
metadata
.comment
.map("COMMENT '" + escapeSingleQuotedString(_) + "'\n")
- .foreach(builder.append)
+ .foreach(s => builder.append(s))
Review Comment:
```
[WARNING] : [deprecation @ | origin= | version=] -target is deprecated: Use
-release instead to compile against the correct platform API.
[ERROR]
/Users/spark-source/sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala:1047:
type mismatch;
found : (x: Char): builder.type <and> (x: Double): builder.type <and> (x:
Float): builder.type <and> (x: Long): builder.type <and> (x: Int): builder.type
<and> (x: Short): builder.type <and> (x: Byte): builder.type <and> (x:
Boolean): builder.type <and> (s: StringBuilder): builder.type <and> (cs:
CharSequence): builder.type <and> (s: String): builder.type <and> (x: Any):
builder.type (with underlying type (x: Char): builder.type <and> (x: Double):
builder.type <and> (x: Float): builder.type <and> (x: Long): builder.type <and>
(x: Int): builder.type <and> (x: Short): builder.type <and> (x: Byte):
builder.type <and> (x: Boolean): builder.type <and> (s: StringBuilder):
builder.type <and> (cs: CharSequence): builder.type <and> (s: String):
builder.type <and> (x: Any): builder.type)
required: String => ?
[WARNING]
/Users/spark-source/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala:131:
[deprecation @
org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormat.prepareWrite
| origin=org.apache.parquet.hadoop.ParquetOutputFormat.ENABLE_JOB_SUMMARY |
version=] value ENABLE_JOB_SUMMARY in class ParquetOutputFormat is deprecated
[ERROR]
/Users/spark-source/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowCreateTableExec.scala:69:
type mismatch;
found : (x: Char): builder.type <and> (x: Double): builder.type <and> (x:
Float): builder.type <and> (x: Long): builder.type <and> (x: Int): builder.type
<and> (x: Short): builder.type <and> (x: Byte): builder.type <and> (x:
Boolean): builder.type <and> (s: StringBuilder): builder.type <and> (cs:
CharSequence): builder.type <and> (s: String): builder.type <and> (x: Any):
builder.type (with underlying type (x: Char): builder.type <and> (x: Double):
builder.type <and> (x: Float): builder.type <and> (x: Long): builder.type <and>
(x: Int): builder.type <and> (x: Short): builder.type <and> (x: Byte):
builder.type <and> (x: Boolean): builder.type <and> (s: StringBuilder):
builder.type <and> (cs: CharSequence): builder.type <and> (s: String):
builder.type <and> (x: Any): builder.type)
required: String => ?
[ERROR]
/Users/spark-source/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowCreateTableExec.scala:122:
type mismatch;
found : (x: Char): builder.type <and> (x: Double): builder.type <and> (x:
Float): builder.type <and> (x: Long): builder.type <and> (x: Int): builder.type
<and> (x: Short): builder.type <and> (x: Byte): builder.type <and> (x:
Boolean): builder.type <and> (s: StringBuilder): builder.type <and> (cs:
CharSequence): builder.type <and> (s: String): builder.type <and> (x: Any):
builder.type (with underlying type (x: Char): builder.type <and> (x: Double):
builder.type <and> (x: Float): builder.type <and> (x: Long): builder.type <and>
(x: Int): builder.type <and> (x: Short): builder.type <and> (x: Byte):
builder.type <and> (x: Boolean): builder.type <and> (s: StringBuilder):
builder.type <and> (cs: CharSequence): builder.type <and> (s: String):
builder.type <and> (x: Any): builder.type)
required: String => ?
[ERROR]
/Users/spark-source/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowCreateTableExec.scala:149:
type mismatch;
found : (x: Char): builder.type <and> (x: Double): builder.type <and> (x:
Float): builder.type <and> (x: Long): builder.type <and> (x: Int): builder.type
<and> (x: Short): builder.type <and> (x: Byte): builder.type <and> (x:
Boolean): builder.type <and> (s: StringBuilder): builder.type <and> (cs:
CharSequence): builder.type <and> (s: String): builder.type <and> (x: Any):
builder.type (with underlying type (x: Char): builder.type <and> (x: Double):
builder.type <and> (x: Float): builder.type <and> (x: Long): builder.type <and>
(x: Int): builder.type <and> (x: Short): builder.type <and> (x: Byte):
builder.type <and> (x: Boolean): builder.type <and> (s: StringBuilder):
builder.type <and> (cs: CharSequence): builder.type <and> (s: String):
builder.type <and> (x: Any): builder.type)
required: String => ?
[WARNING]
/Users/spark-source/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetWrite.scala:93:
[deprecation @
org.apache.spark.sql.execution.datasources.v2.parquet.ParquetWrite.prepareWrite
| origin=org.apache.parquet.hadoop.ParquetOutputFormat.ENABLE_JOB_SUMMARY |
version=] value ENABLE_JOB_SUMMARY in class ParquetOutputFormat is deprecated
[WARNING] three warnings found
[ERROR] four errors found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
