ueshin commented on code in PR #35391: URL: https://github.com/apache/spark/pull/35391#discussion_r975708413
########## python/pyspark/sql/tests/test_dataframe.py: ########## @@ -1107,6 +1107,29 @@ def test_to_pandas_from_mixed_dataframe(self): pdf_with_only_nulls = self.spark.sql(sql).filter("tinyint is null").toPandas() self.assertTrue(np.all(pdf_with_only_nulls.dtypes == pdf_with_some_nulls.dtypes)) + @unittest.skipIf( + not have_pandas or not have_pyarrow, + cast(str, pandas_requirement_message or pyarrow_requirement_message), + ) + def test_to_pandas_for_array_of_struct(self): Review Comment: Could you mark to skip this test if the underlying PyArrow is less than `2.0.0`? ########## python/pyspark/sql/tests/test_pandas_udf_scalar.py: ########## @@ -134,6 +134,30 @@ def test_pandas_udf_nested_arrays(self): result = df.select(tokenize("vals").alias("hi")) self.assertEqual([Row(hi=[["hi", "boo"]]), Row(hi=[["bye", "boo"]])], result.collect()) + def test_pandas_array_struct(self): Review Comment: ditto. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org