lvshaokang commented on code in PR #37986:
URL: https://github.com/apache/spark/pull/37986#discussion_r979990464
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala:
##########
@@ -65,24 +66,27 @@ case class WindowSpecDefinition(
override def checkInputDataTypes(): TypeCheckResult = {
frameSpecification match {
case UnspecifiedFrame =>
- TypeCheckFailure(
- "Cannot use an UnspecifiedFrame. This should have been converted
during analysis. " +
- "Please file a bug report.")
+ DataTypeMismatch(errorSubClass = "UNSPECIFIED_FRAME")
case f: SpecifiedWindowFrame if f.frameType == RangeFrame &&
!f.isUnbounded &&
orderSpec.isEmpty =>
- TypeCheckFailure(
- "A range window frame cannot be used in an unordered window
specification.")
+ DataTypeMismatch(errorSubClass = "RANGE_FRAME_WITHOUT_ORDER")
case f: SpecifiedWindowFrame if f.frameType == RangeFrame &&
f.isValueBound &&
orderSpec.size > 1 =>
- TypeCheckFailure(
- s"A range window frame with value boundaries cannot be used in a
window specification " +
- s"with multiple order by expressions: ${orderSpec.mkString(",")}")
+ DataTypeMismatch(
+ errorSubClass = "RANGE_FRAME_MULTI_ORDER",
+ messageParameters = Map(
+ "orderSpec" -> orderSpec.mkString(",")
+ )
+ )
case f: SpecifiedWindowFrame if f.frameType == RangeFrame &&
f.isValueBound &&
!isValidFrameType(f.valueBoundary.head.dataType) =>
- TypeCheckFailure(
- s"The data type '${orderSpec.head.dataType.catalogString}' used in
the order " +
- "specification does not match the data type " +
- s"'${f.valueBoundary.head.dataType.catalogString}' which is used
in the range frame.")
+ DataTypeMismatch(
+ errorSubClass = "RANGE_FRAME_INVALID_TYPE",
+ messageParameters = Map(
+ "orderSpecType" ->
toSQLType(orderSpec.head.dataType.catalogString),
+ "valueBoundaryType" ->
toSQLType(f.valueBoundary.head.dataType.catalogString)
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
