srowen commented on code in PR #37956:
URL: https://github.com/apache/spark/pull/37956#discussion_r980008367
##########
core/src/main/scala/org/apache/spark/TestUtils.scala:
##########
@@ -285,16 +285,25 @@ private[spark] object TestUtils {
// minimum python supported version changes.
val minimumPythonSupportedVersion: String = "3.7.0"
+ def assumePythonVersionAvailable: Unit =
+ assume(isPythonVersionAvailable,
Review Comment:
Python 3.6 support isn't promised. If one runs with Python 3.6, what should
we do - not test at all? fail? try anyway?
assume() will not even try to test, which seems wrong. require() would fail,
which seems reasonable. It also seems reasonable to do nothing, and just try
the test anyway. So if there is any change here, seems like it would be to fail
explicitly, not skip the test. I could see just not doing anything, too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
