dongjoon-hyun commented on code in PR #38001: URL: https://github.com/apache/spark/pull/38001#discussion_r980867778
########## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ########## @@ -3574,6 +3574,15 @@ object SQLConf { .booleanConf .createWithDefault(false) + val LEGACY_GROUPING_ID_WITH_APPENDED_USER_GROUPBY = + buildConf("spark.sql.legacy.groupingIdWithAppendedUserGroupBy") + .internal() + .doc("When true, grouping_id() returns values based on grouping set columns plus " + + "user-given group-by expressions order.") Review Comment: I added the old versions, `3.2.0, 3.2.1, 3.2.2, and 3.3.0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org