LuciferYang commented on code in PR #37710:
URL: https://github.com/apache/spark/pull/37710#discussion_r981102013
##########
assembly/pom.xml:
##########
@@ -74,6 +74,11 @@
<artifactId>spark-repl_${scala.binary.version}</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.spark</groupId>
+ <artifactId>spark-connect_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review Comment:
Run `dev/make-distribution.sh --tgz` and decompress the generated tar ball,
I found the jars related to `grpc` and `protobuf-java-util-3.19.2.jar` are
also placed in the jars directory as follows:
```
ls -l *grpc*
-rw-r--r-- 1 yangjie01 staff 256991 9 27 18:03 grpc-api-1.47.0.jar
-rw-r--r-- 1 yangjie01 staff 30593 9 27 18:03 grpc-context-1.47.0.jar
-rw-r--r-- 1 yangjie01 staff 689433 9 27 18:03 grpc-core-1.47.0.jar
-rw-r--r-- 1 yangjie01 staff 9129585 9 27 18:03
grpc-netty-shaded-1.47.0.jar
-rw-r--r-- 1 yangjie01 staff 5115 9 27 18:03 grpc-protobuf-1.47.0.jar
-rw-r--r-- 1 yangjie01 staff 7570 9 27 18:03
grpc-protobuf-lite-1.47.0.jar
-rw-r--r-- 1 yangjie01 staff 838576 9 27 18:03 grpc-services-1.47.0.jar
-rw-r--r-- 1 yangjie01 staff 50879 9 27 18:03 grpc-stub-1.47.0.jar
```
should we explicitly exclude them here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
