HyukjinKwon commented on code in PR #38013: URL: https://github.com/apache/spark/pull/38013#discussion_r981863988
########## examples/src/main/python/sql/streaming/structured_network_wordcount_session_window.py: ########## @@ -0,0 +1,130 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +r""" + split lines into words, group by words and use the state per key to track session of each key. + + Usage: structured_network_wordcount_windowed.py <hostname> <port> + <hostname> and <port> describe the TCP server that Structured Streaming + would connect to receive data. + + To run this on your local machine, you need to first run a Netcat server + `$ nc -lk 9999` + and then run the example + `$ bin/spark-submit + examples/src/main/python/sql/streaming/structured_network_wordcount_session_window.py + localhost 9999` +""" +import sys +import math + +from pyspark.sql import SparkSession +from pyspark.sql.functions import explode +from pyspark.sql.functions import split +from pyspark.sql.types import ( + LongType, + StringType, + StructType, + StructField, +) +from pyspark.sql.streaming.state import GroupStateTimeout, GroupState +import pandas as pd +from typing import Iterable, Any Review Comment: Import order should be ``` builtin thridparty pyspark ``` ########## examples/src/main/python/sql/streaming/structured_network_wordcount_session_window.py: ########## @@ -0,0 +1,130 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +r""" + split lines into words, group by words and use the state per key to track session of each key. Review Comment: ```suggestion Split lines into words, group by words and use the state per key to track session of each key. ``` ########## examples/src/main/python/sql/streaming/structured_network_wordcount_session_window.py: ########## @@ -0,0 +1,130 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +r""" + split lines into words, group by words and use the state per key to track session of each key. + + Usage: structured_network_wordcount_windowed.py <hostname> <port> + <hostname> and <port> describe the TCP server that Structured Streaming + would connect to receive data. + + To run this on your local machine, you need to first run a Netcat server + `$ nc -lk 9999` + and then run the example + `$ bin/spark-submit + examples/src/main/python/sql/streaming/structured_network_wordcount_session_window.py + localhost 9999` +""" +import sys +import math + +from pyspark.sql import SparkSession +from pyspark.sql.functions import explode +from pyspark.sql.functions import split +from pyspark.sql.types import ( + LongType, + StringType, + StructType, + StructField, +) +from pyspark.sql.streaming.state import GroupStateTimeout, GroupState +import pandas as pd +from typing import Iterable, Any + +if __name__ == "__main__": + if len(sys.argv) != 3: + msg = "Usage: structured_network_wordcount_session_window.py <hostname> <port>" + print(msg, file=sys.stderr) + sys.exit(-1) + + host = sys.argv[1] + port = int(sys.argv[2]) + + spark = SparkSession.builder.appName( + "StructuredNetworkWordCountSessionWindow" + ).getOrCreate() + + spark.sparkContext.setLogLevel("WARN") + + # Create DataFrame representing the stream of input lines from connection to host:port + lines = ( + spark.readStream.format("socket") + .option("host", host) + .option("port", port) + .option("includeTimestamp", "true") + .load() + ) + + # Split the lines into words, retaining timestamps + # split() splits each line into an array, and explode() turns the array into multiple rows Review Comment: Can we comment that what becomes the `sessionId`? ########## examples/src/main/python/sql/streaming/structured_network_wordcount_session_window.py: ########## @@ -0,0 +1,130 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +r""" + split lines into words, group by words and use the state per key to track session of each key. + + Usage: structured_network_wordcount_windowed.py <hostname> <port> + <hostname> and <port> describe the TCP server that Structured Streaming + would connect to receive data. + + To run this on your local machine, you need to first run a Netcat server + `$ nc -lk 9999` + and then run the example + `$ bin/spark-submit + examples/src/main/python/sql/streaming/structured_network_wordcount_session_window.py + localhost 9999` +""" +import sys +import math + +from pyspark.sql import SparkSession +from pyspark.sql.functions import explode +from pyspark.sql.functions import split +from pyspark.sql.types import ( + LongType, + StringType, + StructType, + StructField, +) +from pyspark.sql.streaming.state import GroupStateTimeout, GroupState +import pandas as pd +from typing import Iterable, Any + +if __name__ == "__main__": + if len(sys.argv) != 3: + msg = "Usage: structured_network_wordcount_session_window.py <hostname> <port>" + print(msg, file=sys.stderr) + sys.exit(-1) + + host = sys.argv[1] + port = int(sys.argv[2]) + + spark = SparkSession.builder.appName( + "StructuredNetworkWordCountSessionWindow" + ).getOrCreate() + + spark.sparkContext.setLogLevel("WARN") + + # Create DataFrame representing the stream of input lines from connection to host:port + lines = ( + spark.readStream.format("socket") + .option("host", host) + .option("port", port) + .option("includeTimestamp", "true") + .load() + ) + + # Split the lines into words, retaining timestamps + # split() splits each line into an array, and explode() turns the array into multiple rows + events = lines.select( + explode(split(lines.value, " ")).alias("sessionId"), + lines.timestamp.cast("long"), + ) + session_fields = [ + StructField("sessionId", StringType()), + StructField("count", LongType()), + StructField("start", LongType()), + StructField("end", LongType()), + ] + + def func( + key: Any, pdf_iter: Iterable[pd.DataFrame], state: GroupState + ) -> Iterable[pd.DataFrame]: + if state.hasTimedOut: + count, start, end = state.get + state.remove() + yield pd.DataFrame( + { + "sessionId": [key[0]], + "count": [count], + "start": [start], + "end": [end], + } + ) + else: + start = math.inf + end = 0 + count = 0 + for pdf in pdf_iter: + start = min(start, min(pdf["timestamp"])) + end = max(end, max(pdf["timestamp"])) + count = count + len(pdf) + if state.exists: + old_session = state.get + count = count + old_session[0] + start = old_session[1] + end = max(end, old_session[2]) + state.update((count, start, end)) + state.setTimeoutDuration(10000) + yield pd.DataFrame() + + # Group the data by window and word and compute the count of each group + sessions = events.groupBy(events["sessionId"]).applyInPandasWithState( + func, + StructType(session_fields), Review Comment: Can we have two separate variables for these schemas? ########## examples/src/main/python/sql/streaming/structured_network_wordcount_session_window.py: ########## @@ -0,0 +1,130 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +r""" + split lines into words, group by words and use the state per key to track session of each key. + + Usage: structured_network_wordcount_windowed.py <hostname> <port> + <hostname> and <port> describe the TCP server that Structured Streaming + would connect to receive data. + + To run this on your local machine, you need to first run a Netcat server + `$ nc -lk 9999` + and then run the example + `$ bin/spark-submit + examples/src/main/python/sql/streaming/structured_network_wordcount_session_window.py + localhost 9999` +""" +import sys +import math + +from pyspark.sql import SparkSession +from pyspark.sql.functions import explode +from pyspark.sql.functions import split +from pyspark.sql.types import ( + LongType, + StringType, + StructType, + StructField, +) +from pyspark.sql.streaming.state import GroupStateTimeout, GroupState +import pandas as pd +from typing import Iterable, Any + +if __name__ == "__main__": + if len(sys.argv) != 3: + msg = "Usage: structured_network_wordcount_session_window.py <hostname> <port>" + print(msg, file=sys.stderr) + sys.exit(-1) + + host = sys.argv[1] + port = int(sys.argv[2]) + + spark = SparkSession.builder.appName( + "StructuredNetworkWordCountSessionWindow" + ).getOrCreate() + + spark.sparkContext.setLogLevel("WARN") Review Comment: Seems like we don;t do this in other examples. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
