amaliujia commented on code in PR #38037: URL: https://github.com/apache/spark/pull/38037#discussion_r982876885
########## python/pyspark/sql/connect/client.py: ########## @@ -21,18 +21,20 @@ import typing import uuid -import grpc +import grpc # type: ignore import pandas import pandas as pd import pyarrow as pa import pyspark.sql.connect.proto as pb2 import pyspark.sql.connect.proto.base_pb2_grpc as grpc_lib +import pyspark.sql.types Review Comment: This import will against the principle of the connect client which should be a light module without, for example, requiring to install pyspark? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
