itholic commented on code in PR #38039:
URL: https://github.com/apache/spark/pull/38039#discussion_r982967471
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##########
@@ -167,9 +172,13 @@ default boolean tableExists(Identifier ident) {
* @param partitions transforms to use for partitioning data in the table
* @param properties a string map of table properties
* @return metadata for the new table
- * @throws TableAlreadyExistsException If a table or view already exists for
the identifier
+ * @throws TableAlreadyExistsException If a table or view already exists for
the identifier. The
+ * error message should contain the
qualified table name,
Review Comment:
qq: maybe it should be "qualified table or view name" ?
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##########
@@ -167,9 +172,13 @@ default boolean tableExists(Identifier ident) {
* @param partitions transforms to use for partitioning data in the table
* @param properties a string map of table properties
* @return metadata for the new table
- * @throws TableAlreadyExistsException If a table or view already exists for
the identifier
+ * @throws TableAlreadyExistsException If a table or view already exists for
the identifier. The
+ * error message should contain the
qualified table name,
+ * including the catalog name.
* @throws UnsupportedOperationException If a requested partition transform
is not supported
- * @throws NoSuchNamespaceException If the identifier namespace does not
exist (optional)
+ * @throws NoSuchNamespaceException If the identifier namespace does not
exist (optional). The
+ * error message should contain the
qualified table name,
Review Comment:
qq: Maybe "qualified namespace name" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
