attilapiros commented on code in PR #31871:
URL: https://github.com/apache/spark/pull/31871#discussion_r983907524
##########
core/src/main/scala/org/apache/spark/executor/ExecutorMetricsPoller.scala:
##########
@@ -124,17 +124,11 @@ private[spark] class ExecutorMetricsPoller(
*/
def onTaskCompletion(taskId: Long, stageId: Int, stageAttemptId: Int): Unit
= {
// Decrement the task count.
- // Remove the entry from stageTCMP if the task count reaches zero.
def decrementCount(stage: StageKey, countAndPeaks: TCMP): TCMP = {
val countValue = countAndPeaks.count.decrementAndGet()
Review Comment:
@Ngone51 we should revisit the assert as
https://issues.apache.org/jira/browse/SPARK-34779?focusedCommentId=17610965&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17610965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
