zhengruifeng commented on code in PR #38031:
URL: https://github.com/apache/spark/pull/38031#discussion_r984122514
##########
python/pyspark/pandas/tests/test_dataframe.py:
##########
@@ -6076,7 +6076,13 @@ def test_corrwith(self):
def _test_corrwith(self, psdf, psobj):
pdf = psdf.to_pandas()
pobj = psobj.to_pandas()
- for method in ["pearson", "spearman", "kendall"]:
+ # Regression in pandas 1.5.0 when other is Series and method is
"pearson" or "spearman"
+ # See https://github.com/pandas-dev/pandas/issues/48826
+ if LooseVersion(pd.__version__) >= LooseVersion("1.5.0") and
isinstance(pobj, pd.Series):
+ methods = ["kendall"]
Review Comment:
why also skipping `pearson `? it is also changed in pandas 1.5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
