mposdev21 commented on code in PR #37972:
URL: https://github.com/apache/spark/pull/37972#discussion_r984123061
##########
connector/proto/pom.xml:
##########
@@ -0,0 +1,119 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
B) Protobuf serialization with confluent schema registry adds schemaId,
MAGIC_BYTE etc. to the message. Don't we want to keep that out of open source ?
C) Map comes in as Message type. We do have a test case in
ProtoFunctiosSuite. For example, a map with string type as "keys" and integer
type as values will look like this when we deserialize:
StructField(map_name_age,
ArrayType(
StructType(
StructField(key,StringType,true),
StructField(value,IntegerType,true)
),false),
false)
C) Okay, we will look into this and come back with a proposal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
