brkyvz commented on code in PR #38113:
URL: https://github.com/apache/spark/pull/38113#discussion_r989296852
##########
connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala:
##########
@@ -139,11 +141,19 @@ private[sql] object AvroOptions {
new AvroOptions(CaseInsensitiveMap(parameters), hadoopConf)
}
- val ignoreExtensionKey = "ignoreExtension"
+ val IGNORE_EXTENSION_KEY = Value("ignoreExtension")
Review Comment:
Let's just expose a `Seq[String]` that contains these options. Another
option is to create a trait like:
```
trait FormatOptions {
// Use reflection to get list of all fields that are strings
}
```
Then you add a unit test that hardcodes how many parameters are found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
