amaliujia commented on code in PR #37994:
URL: https://github.com/apache/spark/pull/37994#discussion_r989392574
##########
connector/connect/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -159,4 +159,17 @@ message Expression {
// UnresolvedStar is used to expand all the fields of a relation or struct.
message UnresolvedStar {
}
+
+ // An resolved attribute that can specify a reference (e.g. column) without
needing a resolution
+ // by the analyzer.
+ message Attribute {
+ string name = 1;
+ // TODO: Full definition of an attribute is at
https://github.com/apache/spark/blob/4f4a080a78c3979961e8483aace663bdc45f489d/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala#L105
+ // bool Nullability = 2;
+ // repeated string Qualifier = 3;
+ // int64 exprId = 4;
+ // string UUID = 6;
Review Comment:
removed
##########
connector/connect/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -159,4 +159,17 @@ message Expression {
// UnresolvedStar is used to expand all the fields of a relation or struct.
message UnresolvedStar {
}
+
+ // An resolved attribute that can specify a reference (e.g. column) without
needing a resolution
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
