brkyvz commented on code in PR #38113:
URL: https://github.com/apache/spark/pull/38113#discussion_r989595596
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala:
##########
@@ -3381,6 +3381,10 @@ abstract class JsonSuite
}
}
}
+
+ test("SPARK-40667: check the number of valid Json options") {
+ assert(JSONOptions.getAllValidOptionNames.size == 28)
Review Comment:
We should leave a comment on what should the users be wary of when they
change this number, otherwise it's just going to piss off developers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
