zhengruifeng commented on code in PR #38148:
URL: https://github.com/apache/spark/pull/38148#discussion_r989860278
##########
python/pyspark/pandas/tests/test_generic_functions.py:
##########
@@ -200,6 +200,22 @@ def test_stat_functions(self):
self.assert_eq(pdf.b.kurtosis(), psdf.b.kurtosis())
self.assert_eq(pdf.c.kurtosis(), psdf.c.kurtosis())
+ def test_prod_precision(self):
Review Comment:
this test will fail in original implementation due to precision loss
the new implementation will provide the precise result for integral inputs,
when the product in [Long.MinValue, Long.MaxValue]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
