cloud-fan commented on code in PR #37819:
URL: https://github.com/apache/spark/pull/37819#discussion_r990166936
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala:
##########
@@ -121,7 +120,7 @@ case class BroadcastExchangeExec(
// and only 70% of the slots can be used before growing in
UnsafeHashedRelation,
// here the limitation should not be over 341 million.
(BytesToBytesMap.MAX_CAPACITY / 1.5).toLong
- case _ => 512000000
Review Comment:
This hardcoded value is probably the physical limitation. If we want
fine-grained control over broadcast join decisions, we can probably add a
config that is similar to `spark.sql.autoBroadcastJoinThreshold` and is based
on number of rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
