beliefer commented on code in PR #37825:
URL: https://github.com/apache/spark/pull/37825#discussion_r990569446
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala:
##########
@@ -254,7 +254,9 @@ object RewriteDistinctAggregates extends Rule[LogicalPlan] {
// Setup unique distinct aggregate children.
val distinctAggChildren = distinctAggGroups.keySet.flatten.toSeq.distinct
- val distinctAggChildAttrMap =
distinctAggChildren.map(expressionAttributePair)
+ val distinctAggChildAttrMap = distinctAggChildren.map { e =>
+ e.canonicalized -> AttributeReference(e.sql, e.dataType, nullable =
true)()
Review Comment:
It seems we can update `expressionAttributePair`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
