Ngone51 commented on code in PR #37924:
URL: https://github.com/apache/spark/pull/37924#discussion_r991057401
##########
core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala:
##########
@@ -2159,6 +2176,26 @@ private[spark] class DAGScheduler(
}
}
+ /**
+ * Whether executor is decommissioning or decommissioned.
+ * Return true when:
+ * 1. Waiting for decommission start
+ * 2. Under decommission process
+ * Return false when:
+ * 1. Stopped or terminated after finishing decommission
+ * 2. Under decommission process, then removed by driver with other reasons
+ */
+ private[scheduler] def isExecutorDecommissioningOrDecommissioned(
+ taskScheduler: TaskScheduler, bmAddress: BlockManagerId): Boolean = {
+ if (bmAddress != null) {
+ taskScheduler
+ .getExecutorDecommissionState(bmAddress.executorId)
Review Comment:
I saw the comments but IIUC that's not what we wanted here. I think what we
wanted here is to return true as long as the executor is being decommissioned
or finished decommission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
