gengliangwang commented on code in PR #38147: URL: https://github.com/apache/spark/pull/38147#discussion_r991520849
########## sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out: ########## @@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist" -- !query schema struct<> -- !query output -org.apache.spark.sql.AnalysisException -Table or view not found: not_exist; line 1 pos 14 +org.apache.spark.sql.catalyst.parser.ParseException Review Comment: > but also brings confusion: why do we test double_quoted_identifiers=false in ansi mode? Do you mean "in non-ansi" mode? ########## sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out: ########## @@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist" -- !query schema struct<> -- !query output -org.apache.spark.sql.AnalysisException -Table or view not found: not_exist; line 1 pos 14 +org.apache.spark.sql.catalyst.parser.ParseException Review Comment: > but also brings confusion: why do we test double_quoted_identifiers=false in ansi mode? Do you mean "in non-ansi mode"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
