amaliujia commented on code in PR #38155:
URL: https://github.com/apache/spark/pull/38155#discussion_r991569772
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -129,22 +129,8 @@ message Fetch {
// Relation of type [[Aggregate]].
message Aggregate {
Relation input = 1;
-
- // Grouping sets are used in rollups
- repeated GroupingSet grouping_sets = 2;
-
- // Measures
- repeated Measure measures = 3;
-
- message GroupingSet {
- repeated Expression aggregate_expressions = 1;
- }
-
- message Measure {
- AggregateFunction function = 1;
- // Conditional filter for SUM(x FILTER WHERE x < 10)
- Expression filter = 2;
- }
+ repeated Expression grouping_expressions = 2;
+ repeated AggregateFunction result_expressions = 3;
Review Comment:
@cloud-fan I still keep this as `AggregateFunction`. `proto.Expression` is a
too general type for now.
connect does not have a `NamedExpression`. I will follow up on this to
improve this part.
This PR is to improve the grouping_expressions anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
