cloud-fan commented on code in PR #38200:
URL: https://github.com/apache/spark/pull/38200#discussion_r991867688
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -39,6 +39,38 @@ package object dsl {
.addAllParts(identifier.asJava)
.build())
.build()
+
+ def protoQualifiedAttr: proto.Expression.QualifiedAttribute =
+ proto.Expression.QualifiedAttribute.newBuilder()
+ .setName(identifier.mkString("."))
Review Comment:
I think we can follow the catalyst dsl
1. if we call `protoAttr`, then we parse the name (split by dot) and create
`UnresolvedAttribute`
2. if we call `bool`, then we directly use the name as attribute name and
create `AttributeReference`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
