LuciferYang commented on code in PR #38190:
URL: https://github.com/apache/spark/pull/38190#discussion_r992956201
##########
launcher/src/main/java/org/apache/spark/launcher/JavaModuleOptions.java:
##########
@@ -40,7 +40,8 @@ public class JavaModuleOptions {
"--add-opens=java.base/sun.nio.cs=ALL-UNNAMED",
"--add-opens=java.base/sun.security.action=ALL-UNNAMED",
"--add-opens=java.base/sun.util.calendar=ALL-UNNAMED",
- "--add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED"};
+ "--add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED",
+ "-Djdk.reflect.useDirectMethodHandle=false"};
Review Comment:
It is better to rename `JavaModuleOptions` as `JavaExtraOptions`. Do you
suggest completing the corresponding refactor work in this pr? @dongjoon-hyun
##########
launcher/src/main/java/org/apache/spark/launcher/JavaModuleOptions.java:
##########
@@ -40,7 +40,8 @@ public class JavaModuleOptions {
"--add-opens=java.base/sun.nio.cs=ALL-UNNAMED",
"--add-opens=java.base/sun.security.action=ALL-UNNAMED",
"--add-opens=java.base/sun.util.calendar=ALL-UNNAMED",
- "--add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED"};
+ "--add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED",
+ "-Djdk.reflect.useDirectMethodHandle=false"};
Review Comment:
I think it is better to rename `JavaModuleOptions` as `JavaExtraOptions`. Do
you suggest completing the corresponding refactor work in this pr?
@dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
