EnricoMi commented on PR #38036: URL: https://github.com/apache/spark/pull/38036#issuecomment-1275639606
> since the validation was moved into the SQL side, we may also move the UT into `src/test/scala/org/apache/spark/sql/DataFrameSelfJoinSuite.scala` I am not sure about `DataFrameSelfJoinSuite` to be the best place for this. Though it is the only place where `flatMapCoGroupsInPandas` is currently tested, that test targets at self join ambiguity, hence the `DataFrameSelfJoinSuite`. This test is about keys. I'd rather put it into `DatasetSuite`, which has lots of `groupBy` tests. I would still keep the one test in Python as Scala tests a private method (there is no other way in Scala to evoke the error), while Python tests a public API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
