sadikovi commented on code in PR #38090:
URL: https://github.com/apache/spark/pull/38090#discussion_r994216273
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala:
##########
@@ -456,7 +456,7 @@ class JacksonParser(
schema.existenceDefaultsBitmask(index) = false
} catch {
case e: SparkUpgradeException => throw e
- case NonFatal(e) if isRoot =>
+ case NonFatal(e) =>
Review Comment:
I have tried covering different cases in:
- SPARK-40646: return partial results for JSON arrays with objects
- SPARK-40646: return partial results for objects with values as JSON arrays
I think I am missing a test for map, will add, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]