philwalk commented on PR #38228: URL: https://github.com/apache/spark/pull/38228#issuecomment-1277658127
The change is portable, it removes a trailing slash, if present, to avoid having two consecutive slashes. On Thu, Oct 13, 2022, 07:11 Sean Owen ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In build/spark-build-info > <https://github.com/apache/spark/pull/38228#discussion_r994625461>: > > > @@ -24,7 +24,7 @@ > > RESOURCE_DIR="$1" > mkdir -p "$RESOURCE_DIR" > -SPARK_BUILD_INFO="${RESOURCE_DIR}"/spark-version-info.properties > +SPARK_BUILD_INFO="${RESOURCE_DIR%/}"/spark-version-info.properties > > Is the "%" Windows-specific? this script isn't. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/38228#pullrequestreview-1140762773>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAYGLFR5DQGKHDEXJCI76WTWDADAZANCNFSM6AAAAAARDVFULU> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
