mridulm commented on code in PR #38064:
URL: https://github.com/apache/spark/pull/38064#discussion_r995000085
##########
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala:
##########
@@ -84,6 +91,74 @@ private[spark] class ChunkedByteBuffer(var chunks:
Array[ByteBuffer]) {
}
}
+ /**
+ * write to ObjectOutput with zero copy if possible
+ */
+ override def writeExternal(out: ObjectOutput): Unit = {
+ // we want to keep the chunks layout
+ out.writeInt(chunks.length)
+ chunks.foreach(buffer => out.writeInt(buffer.limit()))
+ chunks.foreach(buffer => out.writeBoolean(buffer.isDirect))
+ var buffer: Array[Byte] = null
+ val bufferLen = ChunkedByteBuffer.COPY_BUFFER_LEN
+
+ getChunks().foreach { chunk => {
Review Comment:
Let us do the `getChunks` at beginning of the method - and use that for the
rest of the method (instead of `this.chunks` above).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
