zhengruifeng commented on code in PR #38130:
URL: https://github.com/apache/spark/pull/38130#discussion_r995620313
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/QueryStageExec.scala:
##########
@@ -151,6 +151,11 @@ abstract class QueryStageExec extends LeafExecNode {
plan.generateTreeString(
depth + 1, lastChildren :+ true, append, verbose, "", false, maxFields,
printNodeId, indent)
}
+
+ override protected[sql] def cleanupResources(): Unit = {
+ plan.cleanupResources()
+ super.cleanupResources()
Review Comment:
I found that there is a internal try-catch in `SortExec's cleanupResources`
in this PR I think it's safe to only add a `try` in `AdaptiveSparkPlanExec`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
