srielau commented on code in PR #37887:
URL: https://github.com/apache/spark/pull/37887#discussion_r995912819
##########
core/src/test/scala/org/apache/spark/SparkFunSuite.scala:
##########
@@ -316,14 +316,22 @@ abstract class SparkFunSuite
} else {
assert(expectedParameters === parameters)
}
- val actualQueryContext = exception.getQueryContext()
- assert(actualQueryContext.length === queryContext.length, "Invalid length
of the query context")
- actualQueryContext.zip(queryContext).foreach { case (actual, expected) =>
- assert(actual.objectType() === expected.objectType(), "Invalid
objectType of a query context")
- assert(actual.objectName() === expected.objectName(), "Invalid
objectName of a query context")
- assert(actual.startIndex() === expected.startIndex(), "Invalid
startIndex of a query context")
- assert(actual.stopIndex() === expected.stopIndex(), "Invalid stopIndex
of a query context")
- assert(actual.fragment() === expected.fragment(), "Invalid fragment of a
query context")
+ if (!queryContext.isEmpty) {
Review Comment:
OK, I have removed all that and checked the contexts (very painful!) and of
dubious value IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
