EnricoMi commented on code in PR #38256:
URL: https://github.com/apache/spark/pull/38256#discussion_r996067122
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala:
##########
@@ -876,6 +876,24 @@ class AnalysisErrorSuite extends AnalysisTest {
"[`a`, `b`, `c`, `d`, `e`]"
:: Nil)
+ errorTest(
Review Comment:
done
##########
sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala:
##########
@@ -1992,6 +1992,33 @@ class DatasetSuite extends QueryTest
}
}
+ test("SPARK-39783: Fix error messages for columns with dots/periods") {
+ forAll(dotColumnTestModes) { (caseSensitive, colName) =>
+ val ds = Seq(SpecialCharClass("1", "2")).toDS
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> caseSensitive) {
+ val errorMsg = intercept[AnalysisException] {
+ // Note: ds(colName) has different semantics than ds.select(colName)
+ ds.select(colName)
+ }
+ assert(errorMsg.getMessage.contains(
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
