grundprinzip commented on code in PR #38270:
URL: https://github.com/apache/spark/pull/38270#discussion_r996425341
##########
python/pyspark/sql/connect/column.py:
##########
@@ -161,7 +161,7 @@ def to_plan(self, session: Optional["RemoteSparkSession"])
-> proto.Expression:
return self.ref.to_plan(session)
-class ScalarFunctionExpression(Expression):
+class ScalarFunctionExpression(ColumnRef):
Review Comment:
I'll refactor this to make the difference between Expression and ColumnRef
clear. Essentially, I'll move all of the binary operators up to the Expression
class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
