MaxGekk commented on code in PR #38273:
URL: https://github.com/apache/spark/pull/38273#discussion_r996481213


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -256,6 +256,11 @@
     ],
     "sqlState" : "22008"
   },
+  "DECIMAL_PRECISION_EXCEEDS_MAX_PRECISION" : {

Review Comment:
   > I can work on changing those cases to assert additionally the class 
name/msg using checkError ...
   
   Please, do that. The purpose is to make the tests independent from error 
messages (only valuable message parameters), so, in this way tech editors could 
edit error message in error-classes.json and don't worry about internal Spark 
tests. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to