amaliujia commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r996585683
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -167,3 +168,12 @@ message LocalRelation {
repeated Expression.QualifiedAttribute attributes = 1;
// TODO: support local data.
}
+
+// Relation of type [[Sample]] that samples a fraction of the dataset.
Review Comment:
@HyukjinKwon Apache Beam's documentation for proto (which is from Google
internal proto documentation style) is inspiring:
https://github.com/apache/beam/blob/master/model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto.
Eventually I think we will need do the same. Given that this proto is also
an API layer, we gonna document on every of the field with semantic and
examples. It will take time though once our proto becomes stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
