amaliujia commented on code in PR #38275:
URL: https://github.com/apache/spark/pull/38275#discussion_r997226454
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -123,8 +123,16 @@ message Union {
// Relation of type [[Fetch]] that is used to read `limit` / `offset` rows
from the input relation.
message Fetch {
Review Comment:
This is from the original PR which I believe follows SQL semantic. In SQL,
offset is something that working with limit. It is limit first then offset.
However in DataFrame this is not the case where offset is an independent
operation. I updated PR to decouple this two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
